Conversation
|
Bito Automatic Review Skipped - Branch Excluded |
flyteidl2/workflow/run_service.proto
Outdated
| common.TriggerName trigger_name = 6; | ||
|
|
||
| // Task identifier for filtering runs | ||
| task.TaskIdentifier task_id = 7; |
There was a problem hiding this comment.
Also would love to add TaskName here as well as a potential filter. It is the same value was underneath the hood just without the version field. We should built this functionality in now as we will likely want it in the future :)
There was a problem hiding this comment.
@squiishyy Yup! Just added TaskName here as a filter. I will wait for this PR to be merged first and the main PR will checkout to the latest commit hash of flyte2 submodule.
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
|
Bito Automatic Review Skipped - Branch Excluded |
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
|
Bito Automatic Review Skipped - Branch Excluded |
4 participants
Tracking issue
n/a
Why are the changes needed?
We need to update proto for ListRuns api scope by task identifier
What changes were proposed in this pull request?
Update run_service.proto and regenerate
How was this patch tested?
Test in parent PR
Check all the applicable boxes